Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export (const.)core.v2rayKey #831

Merged
merged 2 commits into from
Apr 2, 2021
Merged

feat: export (const.)core.v2rayKey #831

merged 2 commits into from
Apr 2, 2021

Conversation

rurirei
Copy link
Contributor

@rurirei rurirei commented Mar 31, 2021

as for #698

ctx initialization for core.Dial() requires this, as from core.RequireFeatures() introduced in dispatcher.newFakeDNSSniffer().

ctx = context.WithValue(ctx, vcore.V2rayKeyValue, p.v)

@kslr kslr merged commit 102e329 into v2fly:master Apr 2, 2021
@kslr
Copy link
Contributor

kslr commented Apr 2, 2021 •
edited
Loading

Thanks for your Work. :)

@rurirei rurirei deleted the v2rayKey branch April 2, 2021 10:56
xiaokangwang added a commit that referenced this pull request Apr 2, 2021
@xiaokangwang
Revert "feat: export (const.)core.v2rayKey (#831)"
e31bfe0 
This reverts commit 102e329
@xiaokangwang
Copy link
Contributor

@rurirei

I am really sorry that I have to revert your change.

This variable cannot be make a public API of V2Ray, it may subject to change in the future. Instead, I have updated the code so that Dial will automatically set instance context variable. (fc73774)

Will this work in your case?

@rurirei
Copy link
Contributor Author

rurirei commented Apr 2, 2021

@rurirei thanks, i'll try it.

This was referenced Apr 2, 2021
Merged
Merged
@xiaokangwang xiaokangwang mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rurirei @kslr @xiaokangwang